-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh the API #202
Refresh the API #202
Conversation
P.S. This should fix #193 |
@sanguinariojoe Congratulations on the new baby! I will review these and merge |
OK, I am merging this and let see if on the next release someone complains about something |
@sanguinariojoe I'm not entirely sure where things changed here but the fairlead output channel values are now different. See the attached input file as an example, and the image comparing outputs to MDF. I suspect it has to do with changing the getNodeTen function. I looked around a bit and changing the fairlead output written (at line 539 in Line.cpp) to Commit 08ed0e0 and earlier does not have this problem, MDC and MDF agreed exactly on values. Something in the changes in this PR broke the fairlead output values. |
Yeah, the former Now That is consistent with some other instances, as well as some other codes in the wild. The problem is that I have not updated the output channels. |
Well, this was not really a exciting task, but someone should do that...
I just added a bunch of methods to the C API, set the initial state of the coupled bodies (so calling to
MoorDyn_GetBodyState()
beforeMoorDyn_Init()
is giving back the correct result) and updated the wrappers.Tomorrow I am getting a new baby, so I will be unresponsive for a while. @RyanDavies19 feel free to merge/change whatever you need